refactor(runtime): Rehome legacy admin adapters#1167
Merged
Conversation
Move the page-oriented legacy runtime adapters into network.crypta.runtime.admin and construct them through AdminRuntimePortsFactory. Update LegacyRuntimePorts to consume the bundle, move the direct adapter tests into the new package, and keep LegacyRuntimePortsTest verifying the relocated concrete types without widening adapter visibility. Also add doclint-clean Javadoc for the newly added admin package files.
Preserve the original NodeL10n base around UserAlertManagerTest's test translation setup so the suite does not leak a test-only bundle into later runtime/admin tests. This makes the full Gradle test run order-independent again.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
network.crypta.node.runtimeintonetwork.crypta.runtime.adminAdminRuntimePortsFactoryandAdminRuntimePortsBundlesoLegacyRuntimePortsconsumes the moved adapter cluster without directly constructing those concrete classesnetwork.crypta.runtime.admin, keepLegacyRuntimePortsTestin place, and keep the new package docs doclint-cleanValidation
Notes
runtime-spipublic API changessettings.gradle.ktschangesArchive.zipfile was intentionally left out of the branch